search

silverfin / silverfin-cli

Command line tool for Silverfin template development
4 stars 1 forks source link

feature: support running liquid tests for account templates #130

Open Woetfin opened 5 months ago

Woetfin commented 5 months ago

Description

Support running liquid tests for account templates

Some example templates to test you can find here: account_templates.zip

The tests run, but there seem to be two issues that at first glance might be core issues that ENG needs to solve:

  1. Difference in reconciled expectation output on platform compared to API

When I run the tests on this template on the platform: https://live.getsilverfin.com/f/14400/account_detail_templates/492722/edit

All the tests pass on the platform. Screenshot 2024-05-23 at 10 43 20

But running that exact same test suite with the API, results in a different reconciled expectation output: Screenshot 2024-05-23 at 10 44 20

  1. The HTML seems to always return the export view of the template, even if mode "input" or "all" is specified:

Running the test with only expected input view rendered for the template: Screenshot 2024-05-23 at 10 47 04

Still results in the export view being returned by the API: Screenshot 2024-05-23 at 10 30 35

Type of change

Checklist