silverfin / silverfin-cli

Command line tool for Silverfin template development
4 stars 1 forks source link

Config: account templates mapping_list_ranges across firms #99

Closed AgustinSilverfin closed 7 months ago

AgustinSilverfin commented 9 months ago

Describe the bug Mapping List ranges are currently stored as follows:

  "mapping_list_ranges": [
    {
      "account_mapping_list_id": 458,
      "account_range": "4__7"
    },
    {
      "account_mapping_list_id": 459,
      "account_range": "4__7"
    }
  ],

But, the mapping list id is dependent on the firm, so using the same template in another firm will raise error if the mapping list id doesn't exist (which it won't exist, it will have a different id)

Edit: also consider this comment related to mapping list and partners api

Woetfin commented 7 months ago

Should be resolved by #86