DBBoolean are actually int under the hood

silverleague / silverstripe-ideannotator

Generate docblocks for DataObjects, Page, PageControllers and (Data)Extensions

BSD 3-Clause "New" or "Revised" License

46 stars 25 forks source link

DBBoolean are actually int under the hood #166

Open lekoala opened 6 months ago

lekoala commented 6 months ago

I would suggest using this as the default

      SilverStripe\ORM\FieldType\DBBoolean: bool|int

Because internally DBBoolean is a tinyint with 0|1 value, but accepting true/false as well

Firesphere commented 6 months ago

Yeah, might be a good idea. Just wondering, don't want to break compatibility with older versions. Haven't had a close look or anything, so I might be a bit overly cautious.