generics

[lekoala]

hi,

recently upgraded my project to ss 5.3

is there any plan to change things for @method blocks ?

thanks :)

[Firesphere]

Not that I'm aware of... Is there anything that needs changing for 5.3? I hadn't noticed any problems...

[lekoala]

well, they don't need changing, but they really benefit from it eg

• @method \SilverStripe\ORM\DataList|MyObject MyObjects()

becomes

• @method \SilverStripe\ORM\DataList<\MyObject> MyObjects()

i have this project where i use phpstan and this really helped a lot

[lekoala]

in ss5.3, they also added things like

• @template T of object */ abstract class Extension

which implies that any class extending Extension should specify what T is (really annoying, but easy to automate)

more difficult, we have this

• @template T of RequestHandler|DataObject
• @extends Extension */ class VersionedStateExtension extends Extension

and this is where it gets messy, because pages are mixins within controllers, and I didn't manage to get something that makes phpstan happy so far (it's probably a right mix of extends/implements rules to find)

https://phpstan.org/blog/generics-in-php-using-phpdocs#class-level-generics

[Firesphere]

Ah, that sounds useful indeed. I'm currently not living in the Silverstripe world much, so I've not kept up with the latest changes :)