search

silvermine / dynamodb-table-sync

MIT License
45 stars 15 forks source link

feat: add Docker support #16

Closed echernyavskiy closed 4 years ago

echernyavskiy commented 4 years ago

If the PR looks okay, perhaps you could also configure automated builds on Docker hub?

jthomerson commented 4 years ago

Also: a note for @pbredenberg - when you get to the Node upgrade on this repo, we'd need to upgrade the version used in Docker

echernyavskiy commented 4 years ago

@jthomerson LGTM, thanks.

jthomerson commented 4 years ago

@echernyavskiy thanks. I published @silvermine/dynamodb-table-sync@1.2.0 with all your changes

echernyavskiy commented 4 years ago

@jthomerson, awesome, thanks! Any thoughts on also configuring automated builds on Docker Hub?

jthomerson commented 4 years ago

@echernyavskiy that's something I'd be interested in doing, but we haven't ever published anything there before, and we're all pretty swamped with work right now, so I just don't have the time to even look into it right now. To do it right, I'm assuming we'd need to set up an organization there, with multiple of our team members having access, etc, etc.

Feel free to open an issue here if you'd like so we don't forget about the idea.

echernyavskiy commented 4 years ago

Yup, that's exactly right: create an organization and give Docker Hub access to Github. I'll create an issue, thanks.