Support existing Cloudfront distributions

silvermine / serverless-plugin-cloudfront-lambda-edge

Adds Lambda@Edge support to Serverless

MIT License

296 stars 41 forks source link

Support existing Cloudfront distributions #41

Closed ChristophP closed 5 years ago

ChristophP commented 5 years ago

The plugin currently expects a logical name for distribution in the config. It would be great to also support preexisting cloudfront distribution.

Benefits:

integrates better for people working with other infrastructure as code tools, such as terraform.
can help speed up deployments since cloudfront usually takes more than 20 minutes to provision.
allows for keeping the buckets and other resources in different regions (lambda@edge needs to be in us-east-1 and serverless doesn't support multi-region deployments as far as I know)

Easy fix would be accepting a cloudfront id or arn as well.

jthomerson commented 5 years ago

I suggest you always search issues for a project before opening a new one. For example, a search for "existing" would've netted you some very detailed responses that clearly explain why your request can't be supported, and provide alternatives.

Remember, every minute open source maintainers are responding to "the same question, yet again" is a minute that we're not writing the software you know and love 😉

ChristophP commented 5 years ago

Got it :+1: Will do. Didn't mean to waste your time but I am sort of active in the Elm community where not looking for existing issues is encouraged so that maintainers have more data points about certain issues. I get your point though. Thanks

jthomerson commented 5 years ago

Interesting. Hadn't considered it from that angle. Thanks @ChristophP!