search

silvermine / serverless-plugin-external-sns-events

MIT License
26 stars 15 forks source link

Add SourceArn to Lambda perms #6

Closed davekonopka closed 7 years ago

davekonopka commented 7 years ago

Adds SourceArn attribute to the AWS::Lambda::Permission resource. Amazon adds this field to the permission when subscribing Lambda to SNS through the web interface. Adding it here gets the web panel working as expected.

Fixes #5

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 22.222% when pulling 55ff8dff4d74d3801fee7d3a2e0c937342a4cf4c on davekonopka:lambda-perm-source into ecdd1752ab1217cfc8ced3861b44e6190a953014 on silvermine:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+6.7%) to 28.889% when pulling 84753e6459a9f76f6ee2e1d30a90605816fa5540 on davekonopka:lambda-perm-source into ecdd1752ab1217cfc8ced3861b44e6190a953014 on silvermine:master.

davekonopka commented 7 years ago

@jthomerson Is it likely that you will consider this PR? Wondering if I should start using my own fork.

gmetzker commented 7 years ago

@davekonopka FYI I also wanted your change and have it on my internal branch as well. Part of my pull request as well: https://github.com/silvermine/serverless-plugin-external-sns-events/pull/8

jthomerson commented 7 years ago

Closed with #11