search

silvermine / videojs-chromecast

MIT License
148 stars 75 forks source link

SCSS deprecation warning #100

Closed davidmfoley closed 2 years ago

davidmfoley commented 3 years ago

We import the videojs-chromecast scss into our project as specified here.

We see the following deprecation warning when building: 

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($chromecast-poster-width, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
24 │          left: calc(50% - #{$chromecast-poster-width / 2});
   │                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    ../node_modules/@silvermine/videojs-chromecast/src/scss/_tech.scss 24:29             @import
    ../node_modules/@silvermine/videojs-chromecast/src/scss/videojs-chromecast.scss 2:9  @import
jthomerson commented 3 years ago

Well-tested pull requests welcome.