fix: scss deprecation warning

silvermine / videojs-chromecast

MIT License

148 stars 75 forks source link

fix: scss deprecation warning #106

Closed edgarsn closed 2 years ago

edgarsn commented 2 years ago

Fixes #100

Since dividing number by 2 is the same as multiplying it by 0.5, this fix will work great in current and next sass major version.

P.s. sorry about previous PR. After travis failed because of commit messages, I read everything in Contribution section and decided to close it, because probably it wouldn't be merged.

coveralls commented 2 years ago

Coverage remained the same at 0.0% when pulling e34563986162b66955a0ce8147387755f49e40b3 on edgarsn:scss-deprecation-warning-fix into e543cae68860890b189090cde16063f97dfa2250 on silvermine:master.

radamant commented 2 years ago

Please merge this. This warning has been spamming my logs for months.

davidmfoley commented 2 years ago

Any chance of merging this?

jthomerson commented 2 years ago

Thanks for the contribution! Sorry for the delays. This is shipped in v1.3.3.