silvermine / videojs-chromecast

MIT License
148 stars 75 forks source link

Support for modifying load request #118

Closed kontrollanten closed 1 year ago

kontrollanten commented 2 years ago

closes #123 closes #141

Thanks to @andreasgan who has written the code, I'm just doing the PR.

coveralls commented 2 years ago

Coverage Status

coverage: 2.627% (-0.03%) from 2.652% when pulling 7cee052dcd5473448f882d67bb5bc9d8e9a1763c on kontrollanten:feat-hls-support into 330385c6ca34fec74c86ea0642274e4e07069d9f on silvermine:master.

kontrollanten commented 2 years ago

@yokuze have you got time to check this?

PaddyLock commented 1 year ago

Do you know how soon this will be merged please?

lewisevans commented 1 year ago

We could really do with this too. Any news? @kontrollanten

kontrollanten commented 1 year ago

I haven't heard anything. @onebytegone, are you willing to merge this?

oliverphardman commented 1 year ago

@jthomerson please would you be able to take a look?

jthomerson commented 1 year ago

@yokuze would be the one that would need to review this, but I'm not sure when he'll have time to do so

ToshY commented 1 year ago

@yokuze Any chance you have time to review this?

yokuze commented 1 year ago

@izkmdz Can you review this when you get a chance?

kontrollanten commented 1 year ago

Hi @izkmdz ! Now I've cleaned up the commits and move the scrubbing fix to #165. I'm not sure how to solve the markdown lint issue though, since the URL's are longer than max line length. I guess the links breaks if I put them on multiple lines.

izkmdz commented 1 year ago

@yokuze Over to you for approval.

yokuze commented 1 year ago

Thank you @kontrollanten / @izkmdz!

Thank you @kontrollanten for your patient and consistent contributions. 😀

ToshY commented 1 year ago

@yokuze Is it possible to tag a new release?