Support Video.js 8.x - Githubissues

silvermine / videojs-chromecast

MIT License

147 stars 74 forks source link

Support Video.js 8.x #147

Closed ToshY closed 1 year ago

ToshY commented 1 year ago

Problem

Upgrading VideoJS from 7.20.3 to 8.0.2 I got dependency conflicts, as apparently its locked between 6 and 8

  "peerDependencies": {
    "video.js": ">= 6 < 8"
  }

The README however states that its for versions 6+.

Expected solution

~~No dependency conflict.~~

Rewriting to be compatible with to 8.X: Migration guide VideoJS 7 to 8:

SoLoR1 commented 1 year ago

Even if there wouldnt be dependency conflict it would not work because:

video.min.js:12 

       VIDEOJS: WARN: videojs.extend is deprecated as of Video.js 7.22.0 and will be removed in Video.js 8.0.0
(anonymous) @ video.min.js:12
n.warn @ video.min.js:12
ir.extend @ video.min.js:20
module.exports @ silvermine-videojs-chromecast.min.js:3704
module.exports @ silvermine-videojs-chromecast.min.js:3790
68../index @ silvermine-videojs-chromecast.min.js:3820
o @ silvermine-videojs-chromecast.min.js:17
r @ silvermine-videojs-chromecast.min.js:24
(anonymous) @ silvermine-videojs-chromecast.min.js:28

ToshY commented 1 year ago

Even if there wouldnt be dependency conflict it would not work because:

video.min.js:12 

       VIDEOJS: WARN: videojs.extend is deprecated as of Video.js 7.22.0 and will be removed in Video.js 8.0.0
(anonymous) @ video.min.js:12
n.warn @ video.min.js:12
ir.extend @ video.min.js:20
module.exports @ silvermine-videojs-chromecast.min.js:3704
module.exports @ silvermine-videojs-chromecast.min.js:3790
68../index @ silvermine-videojs-chromecast.min.js:3820
o @ silvermine-videojs-chromecast.min.js:17
r @ silvermine-videojs-chromecast.min.js:24
(anonymous) @ silvermine-videojs-chromecast.min.js:28

I am aware of this, that's why I added a link to the migration guide which also denotes extend being deprecated in 8.x.

I will update the desired solution so it requires migration as well.