silvermine / videojs-chromecast

MIT License
147 stars 74 forks source link

fix: clear session disconnect timeout on Chromecast Tech dispose #160

Closed ksjun closed 11 months ago

ksjun commented 1 year ago

Because the timer was not cleared even after ChromeTech was dispose.

yokuze commented 11 months ago

This looks good, thank you @ksjun. Could you adjust the commit message to the format described here: https://github.com/silvermine/silvermine-info/blob/master/commit-history.md#commit-messages ?

Something like:

fix: prevent session timeout disconnect after reconnecting

should work. Thanks!

yokuze commented 11 months ago

Sorry @ksjun - You'll have to fixup the commit message itself using git commit --amend, not just the MR title. Thank you!