silvermine / videojs-chromecast

MIT License
148 stars 75 forks source link

chore: run demo https tunneled from localhost #166

Open kontrollanten opened 1 year ago

kontrollanten commented 1 year ago

To be able to actually run the demo it needs to be served behind a server with a valid HTTPS certificate. In order to simplify this, and make it easier to verify and develop this library, a npm script is added to setup the demo behind a HTTPS server in a single command.

A side note: Is it necessary to pin the dependencies in package.json since package-lock.json is introduced?

Update

Added support for:

coveralls commented 7 months ago

Coverage Status

coverage: 18.386%. remained the same when pulling bb29aaf13a451b694f3c561f26e8d0118e10e5da on kontrollanten:feat-kontrollanten-demo into 718c832bcdd1b466bb8c3fbbe72c2d23609504df on silvermine:master.

kontrollanten commented 3 months ago

Hi @onebytegone Do you have any comments on this? I think it's quite a low risk PR since it doesn't affect the existing code. I hope this PR will make it easier for new people to try this package, but also for contributors to test the functionality.