search

silvermine / videojs-chromecast

MIT License
148 stars 75 forks source link

Downgrade class.extend #53

Closed jandor64 closed 5 years ago

jandor64 commented 5 years ago

Avoids the need to allow unsafe-eval in dependency class.extend, issue #52

yokuze commented 5 years ago

@jandor64 The build for this PR is failing because the version of class.extend was updated in package.json but not in package-lock.json. Please use npm install -E class.extend@0.9.1 to update the version of class.extend, and that will update it correctly in both places.

Also, if you wouldn't mind, please update the commit message to reflect our git commit message standards: https://github.com/silvermine/silvermine-info/blob/master/commit-history.md#commit-messages I think all you'd need to do is change the subject line to something like: fix: Unsafe eval in class.extend 0.9.2 (#52)

jthomerson commented 5 years ago

I updated the branch to use npm i to update the package lock, and fix the commit message format