search

silvermine / videojs-chromecast

MIT License
148 stars 75 forks source link

refactor: use es6 classes #98

Closed kontrollanten closed 2 years ago

kontrollanten commented 3 years ago

92 but with the conflicts solved:

Adds babel and uses es6 classes instead of "class.extend".

kontrollanten commented 2 years ago

@yokuze @jthomerson Can I do something to help make this PR merged? We've some other features depending on this, which will add support for PeerTube's HLS to get working with videojs-chromecast.

kontrollanten commented 2 years ago

Thanks for the review, now everything is rebase and should be fixed.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling c5657d06f8c94434ea9c83dd830f86218bba4aaa on kontrollanten:feature/es6-class into 31a4bbb624036b19fb5ef13f3d4126b5db4e1da8 on silvermine:master.

kontrollanten commented 2 years ago

Ping @yokuze

yokuze commented 2 years ago

Thanks @kontrollanten, and thanks @izkmdz for your testing and review.

dwassing commented 2 years ago

@yokuze Will you cut a new package release with this change?