silvermine / videojs-quality-selector

MIT License
180 stars 55 forks source link

Error quality selector with videojs 8.3.0 #101

Closed mr-moco1 closed 9 months ago

mr-moco1 commented 1 year ago

Hi,

I have find an error with videojs 8.3.0. Please find below the code working and if you remplace the commentary for update to 8.3.0 it doesn't work.

<!DOCTYPE html>
<html>
<head>
   <meta charset=utf-8 />
   <link href="https://unpkg.com/video.js@7.5.4/dist/video-js.css" rel="stylesheet">
   <!--<link href="https://vjs.zencdn.net/8.3.0/video-js.css" rel="stylesheet" />-->
   <style>
      body {
        margin: 0;
        padding: 0;
        background-color: var(--bg-color);
        transition: background-color 0.5s ease;
      }

      .video-js {
        width: 100%;
        height: calc(100vh - 40px);
      }

      @media (prefers-color-scheme: dark) {
        body {
          --bg-color: #333;
        }
      }

      @media (prefers-color-scheme: light) {
        body {
          --bg-color: #ccc;
        }
      }
    </style>
   <script src="https://unpkg.com/video.js@7.5.4/dist/video.js"></script>
   <!--<script src="https://vjs.zencdn.net/8.3.0/video.js"></script>-->
   <script src="https://unpkg.com/@silvermine/videojs-quality-selector/dist/js/silvermine-videojs-quality-selector.min.js"></script>
   <link href="https://unpkg.com/@silvermine/videojs-quality-selector/dist/css/quality-selector.css" rel="stylesheet">
</head>
<body>
   <video id="video_1" class="video-js vjs-big-play-centered" controls preload="auto">
      <source src="/stream/v0/master.m3u8" type="application/x-mpegURL" label="1080P">
      <source src="/stream/v1/master.m3u8" type="application/x-mpegURL" label="720P" selected="true">
      <source src="/stream/v2/master.m3u8" type="application/x-mpegURL" label="360P">
   </video>
   <script>
      videojs('video_1', {}, function() {
         var player = this;
         player.controlBar.addChild('QualitySelector');
      });
   </script>
</body>
</html>
yokuze commented 9 months ago

This is addressed in v1.3.1 of this plugin. Thanks!