build: Disable merge_vars in Gruntfile uglify process

silvermine / videojs-quality-selector

MIT License

183 stars 54 forks source link

build: Disable merge_vars in Gruntfile uglify process #113

Closed Timodie closed 1 month ago

Timodie commented 1 month ago

merge_vars aggressively reuses variable names, which can lead to unexpected behavior or runtime errors in certain cases. It was introduced grunt-contrib-uglify 5.0.1 and it is now turned on by default. We are turning it off to ensure it does not break this project.

coveralls commented 1 month ago

coverage: 0.0%. remained the same when pulling c312467a176982b705c569b06529591a7958e31b on Timodie:taddai/turn-off-merge-vars into c7278c8329f41632dcc5ada882062b35d0e1102a on silvermine:master.

kmuncie commented 1 month ago

This looks good to me. @onebytegone can you please merge?