Closed sudoanand closed 5 years ago
@hack4mer please:
1) squash both your commits into one (see https://github.com/silvermine/silvermine-info/blob/master/commit-history.md)
2) do not include the package-lock.json
change into that commit - it's not relevant to this work (@onebytegone we should add that one as a separate commit - not sure how we missed doing that before)
Thanks!
@onebytegone run with it after that.
Hi, sorry about that. I have made the requested changes
package-lock.json
from the commitI have also created another commit in a new branch that updates the package-lock.json
file. I will open a new PR if you say after this one has been reviewed and merged
Thanks for updating the PR @hack4mer! Unless @jthomerson says otherwise, don't worry about a PR for package-lock.json
. There is some NPM "housekeeping" that we need to do, update dependencies and such. It'll be easiest to add the lock file in that update.
Sure, thank you @onebytegone. :)
For the reason @onebytegone and @RyanBertrand mention, I'm closing this.
…-ios mobiles