silvermine / videojs-quality-selector

MIT License
183 stars 54 forks source link

Ref #18: Fixes quality selector options autohide inconsistency on non… #21

Closed sudoanand closed 5 years ago

sudoanand commented 6 years ago

…-ios mobiles

jthomerson commented 6 years ago

@hack4mer please:

1) squash both your commits into one (see https://github.com/silvermine/silvermine-info/blob/master/commit-history.md) 2) do not include the package-lock.json change into that commit - it's not relevant to this work (@onebytegone we should add that one as a separate commit - not sure how we missed doing that before)

Thanks!

@onebytegone run with it after that.

sudoanand commented 6 years ago

Hi, sorry about that. I have made the requested changes

I have also created another commit in a new branch that updates the package-lock.json file. I will open a new PR if you say after this one has been reviewed and merged

onebytegone commented 6 years ago

Thanks for updating the PR @hack4mer! Unless @jthomerson says otherwise, don't worry about a PR for package-lock.json. There is some NPM "housekeeping" that we need to do, update dependencies and such. It'll be easiest to add the lock file in that update.

sudoanand commented 6 years ago

Sure, thank you @onebytegone. :)

jthomerson commented 5 years ago

For the reason @onebytegone and @RyanBertrand mention, I'm closing this.