Closed mcarriere closed 5 years ago
Tested with VideoJS 7 and 6
sure, no problem! I'll split everything in multiple commits and fix my commit messages
hopefully, my 3 commits are now compliant with your commitlint rules. I also added a more detailed explanation to all the commits onto what I changed and why.
@mcarriere Thank you for the PR! Nice job. I have just a couple of feedback items for you in this review. Also, could you update the commit message subject on this commit: b17858a to be 72 characters or less?
Thanks! commit: [b17858a] subject has been fixed, apparently I can't count :/
thanks for accepting this :) Would it be possible to create a new release?
Yes, we should do that soon. However, I'd like to fix #31 first.
@mcarriere this is available in @silvermine/videojs-quality-selector@1.2.1
@mcarriere this is available in
@silvermine/videojs-quality-selector@1.2.1
@jthomerson Thanks a lot! Do you know why it's not on https://www.npmjs.com/package/silvermine-videojs-quality-selector ?
@mcarriere That's the old version of the package. We moved the package to the @silvermine
org a while back: https://www.npmjs.com/package/@silvermine/videojs-quality-selector
ok thx!
...where the menu bar would not fadeout after the quality selector was used. Also updated all the libs in package.json to the latest available.