silvermine / videojs-quality-selector

MIT License
183 stars 54 forks source link

Dist JS files locations changed #31

Closed yokuze closed 5 years ago

yokuze commented 5 years ago

Apparently, when we switched this repo over to use the new @silvermine organization, it also changed the location of the files in dist because we base the name of the JS files on the name of the npm package: https://github.com/silvermine/videojs-quality-selector/blob/master/Gruntfile.js#L35 We should modify the Gruntfile to revert to our previous path for the JS files.

Additionally, it's likely that I didn't notice this when updating the Video.js version in our demo page because this repo does not have a clean step that removes old files when building, as our other repos do. Therefore, the old files were still at the original path and the demo still worked in my local build. It would probably be a good idea to add a clean step to our Gruntfile as well.