silvermine / videojs-quality-selector

MIT License
180 stars 55 forks source link

`TypeError: n.extend is not a function` at the latest version . #98

Closed magic-thomas closed 9 months ago

magic-thomas commented 1 year ago

Hello.

cdn link is used.

/*! @silvermine/videojs-quality-selector 2023-03-21 v1.3.0 */

it gives lvermine-videojs-quality-selector.js:2061 Uncaught TypeError: n.extend is not a function

used videojs version : 8.3.0

I guess the latest source code is rolled back.

arulpatmose commented 1 year ago

Any updated on this issue? Thanks

gsimko commented 1 year ago

Sent https://github.com/silvermine/videojs-quality-selector/pull/99

fguillen commented 11 months ago

Is this solved? duplicated?

fguillen commented 11 months ago

For now, the only solution I found is using VideoJS v7.21.5

magic-thomas commented 11 months ago

For now, the only solution I found is using VideoJS v7.21.5

I agree.

I downgraded video js to 7.x .

gsimko commented 11 months ago

A fix was merged already in https://github.com/silvermine/videojs-quality-selector/pull/93#issuecomment-1725889902

r152a commented 11 months ago

A fix was merged already in #93 (comment)

no changes in https://www.npmjs.com/package/@silvermine/videojs-quality-selector

yokuze commented 9 months ago

This is addressed in v1.3.1 of this plugin. Thanks!