silvershop / silvershop-core

SilverShop is an e-commerce shopping cart module for the SilverStripe CMS
http://silvershop.github.io
BSD 2-Clause "Simplified" License
113 stars 119 forks source link

AddressBook error 'File vendor/silverstripe/admin/thirdparty/jquery/jquery.js does not exist' after upgrade to SS 4.12.1 #781

Closed EEKimS closed 1 year ago

EEKimS commented 1 year ago

It appears that the original jquery file used by the AddressBook class no longer exists after the upgrade, causing the shipping details sections of the multipage checkout to throw errors.

Requirements::javascript('silverstripe/admin:thirdparty/jquery/jquery.js'); on line 37 of AddressBook.php

I am attempting to overload this class to change this address in my project - however, it would be nice to have this fixed for going forward without having to hack the core or manually overload it.

xini commented 1 year ago

Hey EEKimS, We've been using https://github.com/xini/silverstripe-requirements-resolver to override any ancient jQuery versions loaded by other modules. Maybe it helps you here? Cheers

EEKimS commented 1 year ago

Hi @xini, That does seem to have done the trick, thank you very much!

xini commented 1 year ago

Can you please reopen this? I think it still needs fixing.

BettinaMaria98 commented 1 year ago

Hi, something new here? We got this problem too... CMS 4.12.0 SilverShop 3.0.4

xini commented 1 year ago

@BettinaMaria98 SS have again messed up sematic versioning by removing jQuery from framework. You have to include your own version of jQuery. @wernerkrauss are you a maintainer? Can jQuery be included in this module?

BettinaMaria98 commented 1 year ago

@xini thanks for pointing that out, we will do that!

EEKimS commented 1 year ago

Can confirm that the requirements resolver did not help with the issue, still getting the error - and it is proving to be very difficult to include my own in the correct file.

wilr commented 1 year ago

https://github.com/silvershop/silvershop-core/commit/d9d5d4bcc8bf0407ccc9cb4e31a4583b7a117fa8

xini commented 1 year ago

Thanks @wilr !

wernerkrauss commented 1 year ago

Nice solution @wilr