Closed elliot-sawyer closed 1 year ago
Unrelated to the above, when I tried to install silvershop/silverstripe-hasonefield it results in a 500 error when adding it to a DataObject's CMS fields (I think it was Order). That was in a DataExtension so quite possible I was doing something wrong
I've started the work to upgrade this module to Silverstripe 5 and have managed it with very few changes required.
It's not mergeable as-is unless you add my forks to the repositories key to your parent project (composer seems to ignore the upstream ones). The pull requests need to be accepted, so I can update this pull request to use a stable tag, or a specific commit until it is marked stable
The only coding change required was on sqlquerylist, which changed the method signature on
limit
to support type hinting and return types. There may be more to be checked inside the tests, but I haven't gone into those.Once those upstream dependencies are merged in, this should be safe to merge