search

silvershop / silvershop-core

SilverShop is an e-commerce shopping cart module for the SilverStripe CMS
http://silvershop.github.io
BSD 2-Clause "Simplified" License
113 stars 119 forks source link

Update ProductOrderItemTest.php #810

Closed AntonyThorpe closed 9 months ago

AntonyThorpe commented 9 months ago

set $beachBall variable to lowercase. Thanks.

wernerkrauss commented 9 months ago

Hi @AntonyThorpe thanks for that PR ;)

Do you think, mp3player should also be convertet into mp3Player?

AntonyThorpe commented 9 months ago

Hi @wernerkrauss, depends on the coding convention followed by this Repository. PSR-1 recommends a consistent way of declaring properties so one way needs to be chosen. Using camelCase would be consistent when shifting back and forth between PHP & javascript so that would help. To answer your questions, yes. Thanks.

wilr commented 9 months ago

Thanks @AntonyThorpe sorry yes I was trying to clean these up over the weekend to fix the lint errors in VSCode.

Looks like we have tests working again! Yay. Looking at the logs, I think fixing Onimay is next on my list, there is a few warnings and errors in PHP 8+