search

silvershop / silvershop-core

SilverShop is an e-commerce shopping cart module for the SilverStripe CMS
http://silvershop.github.io
BSD 2-Clause "Simplified" License
113 stars 119 forks source link

Deprectate Order->Total() as it conflicts with casting of Total DB field #811

Open wernerkrauss opened 9 months ago

wernerkrauss commented 9 months ago

How about deprecating Order's Total() method and suggest using it's alias instead, GrandTotal()?

It conflicts with casting of Total DB field for e.g. GridField when I want to dispay it with European decimal numbers. (See related #779)

This can be done in the next SS5 main release, as it's a breaking change and I don't know how many modules (or custom installations) use it right now.

Of course we can add a rector for easier upgrading to silverstripe-rector