silvershop / silvershop-discounts

Adds Discount and Coupon support for SilverShop
Other
9 stars 38 forks source link

Improvement: InputFields in Backend ignore ShopCurrency configuration #116

Open MLindenhofer opened 7 months ago

MLindenhofer commented 7 months ago

If there are configurations for ShopCurrency like this:

SilverShop\ORM\FieldType\ShopCurrency:
  decimal_delimiter: '.'
  thousand_delimiter: ','
  currency_symbol: '€'
  # european style currencies, e.g. 45,00 € instead of €45,00
  append_symbol: true

They will only affect the output in frontend. But in Backend the input still sticks with the default config with the english $ currency and the delimiters.

Example: Apply 5,10 for Specific Price with the config from above this will be converted and shown as 5.100 in Frontend because the comma is still evaluated as a thousands delimiter although . was defined for this in the config.

There is progress to improve internationalisation stuff in silvershop-core: https://github.com/silvershop/silvershop-core/issues/818#issue-2169359382

Would be great if this module will also be improved :) to create a better experience for international e-commercers

Best regards