In my local SS4 system the db fields from the various DiscountConstraint subclasses weren't being created. I couldn't figure out why, but I changed some code to fix things.
In a nutshell, the db fields are created when the constraints are added using extensions: in the module's config.yml instead of constraints: in config.yml + DiscountConstraint::set_up_constraints() in the module's _config.php.
My 'fix' is in this commit, which I feel is worth merging, but I'm not sure if it might impact anything else... or if I'm just hacking around a more underlying issue...?
Hi,
In my local SS4 system the db fields from the various DiscountConstraint subclasses weren't being created. I couldn't figure out why, but I changed some code to fix things.
In a nutshell, the db fields are created when the constraints are added using
extensions:in the module's config.yml instead ofconstraints:in config.yml +DiscountConstraint::set_up_constraints()in the module's _config.php.My 'fix' is in this commit, which I feel is worth merging, but I'm not sure if it might impact anything else... or if I'm just hacking around a more underlying issue...?
Thanks, Grant