silversixpence-crypto / zk-proof-of-assets

MIT License
3 stars 0 forks source link

Check that the pubkey is valid in 1 of the circuits #19

Closed Stentonian closed 3 months ago

Stentonian commented 4 months ago

The ecdsa verifier does not check for valid public keys

https://github.com/silversixpence-crypto/zk-proof-of-assets/blob/257f872b07384f73e3581476613120f446196457/circuits/layer_one.circom#L29

Stentonian commented 3 months ago
// Note that there is no need to verify the pubkey because in
// layer 2 it is converted to an Ethereum address, so if the
// pubkey is invalid then so is the address.