search

silverstripe-archive / silverstripe-forum

Forum module for SilverStripe CMS
http://silverstripe.org/forum-module
Other
34 stars 60 forks source link

ENHANCEMENT Posts you don't have permission to reply to should be handled better #168

Closed andrewandante closed 8 years ago

andrewandante commented 9 years ago

At the moment, if you attempt to reply to a post that you cannot (eg. if only admins can reply), you are still able to click 'Reply'. Then the button changes to plain text and a silent 403 is returned.

A better implementation would be to either remove the reply button altogether, preferably with some sort of 'This post is read-only' marker, or to return some sort of 'sorry, you don't have permission to reply to this post' on click.

edlinklater commented 9 years ago

@andrewandante: I can't reproduce this - are you able to give further information, such as which version of the forum module?

dhensby commented 8 years ago

ping @andrewandante

andrewandante commented 8 years ago

Hello, sorry for the tardiness. It will have been version 0.8.0.

I was attempting to post a reply to a forum that should only have been postable by admins and core committers. However, it had been replied to already by one member because the OP hadn't made it read-only like they had intended. Then when I went to reply, it failed in the way described. I haven't had a chance to try and reproduce locally. Will let you know if I come across anything useful.

edlinklater commented 8 years ago

Sorry, I've been unable to reproduce this. Please feel free to re-open with more detail if you come across it again.