search

silverstripe-archive / silverstripe-forum

Forum module for SilverStripe CMS
http://silverstripe.org/forum-module
Other
34 stars 60 forks source link

Move BBCodeParser to Forum #191

Closed Firesphere closed 1 year ago

Firesphere commented 8 years ago

Either move the current BBCodeParser and DBText::Parse() method to the Forum module, as they're not required in core.

Other (in my opinion better) option, is to switch to Golanka/BBCodeParser. It's better maintained, not as old as the one in framework. And has friendlier parsing. Plus easy add codes.

dhensby commented 8 years ago

How about moving to markdown :P

Firesphere commented 8 years ago

That actually sounds like something that would make sense. But... which one? There doesn't seem to be a SilverStripe maintained one?

dhensby commented 8 years ago

Need to create one :)

https://github.com/erusev/parsedown is a good parser and is used on https://github.com/silverstripe/silverstripe-docsviewer

camfindlay commented 7 years ago

+1 for moving forum to markdown

camfindlay commented 7 years ago

Perhaps since some BBCode methods are being dep'd in 4 core, updating this module for 4 compat might make sense to do the markdown move at the same time? (might need a way to ensure old bbcode content in people's databases can be converted to MD too).

DryerLintPurple commented 7 years ago

As another option for replacement, how about s9e\TextFormatter? It looks to be one of the most popular on Packagist, and it supports both BBCode and Markdown, which would be a nice option. The dependency on a package called 'regexp-builder' makes me nervous, though. Hope somebody's doing some serious bad markup/XSS testing!

https://github.com/s9e/TextFormatter https://packagist.org/packages/s9e/text-formatter