silverstripe-archive / silverstripe-forum

Forum module for SilverStripe CMS
http://silverstripe.org/forum-module
Other
34 stars 60 forks source link

Allow Subscribe/Unsubscribe to be called without ajax #205

Closed hailwood closed 7 years ago

hailwood commented 7 years ago

As discussed in #204

codecov-io commented 7 years ago

Codecov Report

Merging #205 into master will decrease coverage by 0.45%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   53.66%   53.21%   -0.46%     
==========================================
  Files          11       11              
  Lines        2115     2118       +3     
==========================================
- Hits         1135     1127       -8     
- Misses        980      991      +11
Impacted Files Coverage Δ
code/pagetypes/Forum.php 58.75% <0%> (-1.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 094b15f...db7cdca. Read the comment docs.

hailwood commented 7 years ago

Hey @dhensby ; Any update on merging this in?

I'm aware that i've lowered code coverage slightly by introducing new lines in a section that isn't tested at all; but I currently don't have enough open-source time to write tests for the entire subscription system..

dhensby commented 7 years ago

Thanks