search

silverstripe-archive / silverstripe-mobile

Mobile support module for SilverStripe CMS
http://silverstripe.org/mobile/
BSD 3-Clause "New" or "Revised" License
35 stars 36 forks source link

SilverStripe Mobile update MobileSiteConfigExtension class #26

Closed otiteca closed 12 years ago

otiteca commented 12 years ago

I did update the class for it to build without errors with /dev/build

Modification:

1) class MobileSiteConfigExtension extends DataExtension 2) public function extraStatics($class = null, $extension = null) 3) public function updateCMSFields(FieldList $fields)

You should push it to the repo.

Olivier

wilr commented 12 years ago

Hi @otiteca, Have you got a recent update of the module as these are fixed (https://github.com/silverstripe/silverstripe-mobile/blob/master/code/MobileSiteConfigExtension.php). Please raise issues you've fixed via pull requests, that way you can save duplication of work! See our guide (http://doc.silverstripe.org/framework/en/trunk/misc/collaboration-on-git) for more information on how to contribute code fixes.

otiteca commented 12 years ago

Hi,

I did not look at the trunk, just downloaded and installed the stable version available on silverstripe.org, and i did that yesterday. Facing with those few issues, i fixed them and posted the fix.

Olivier

On 18/07/2012 07:45, Will Rossiter wrote:

Hi @otiteca, Have you got a recent update of the module as these are fixed (https://github.com/silverstripe/silverstripe-mobile/blob/master/code/MobileSiteConfigExtension.php). Please raise issues you've fixed via pull requests, that way you can save duplication of work! See our guide (http://doc.silverstripe.org/framework/en/trunk/misc/collaboration-on-git) for more information on how to contribute code fixes.

Reply to this email directly or view it on GitHub: https://github.com/silverstripe/silverstripe-mobile/issues/26#issuecomment-7057345