search

silverstripe-archive / silverstripe-newsletter

NewsletterAdmin is the CMS class for managing the newsletter system.
BSD 3-Clause "New" or "Revised" License
69 stars 59 forks source link

undefined variable while submitting subscription form #117

Closed alwex closed 7 years ago

alwex commented 7 years ago

Hi, I am using silverstripe 3.4.x with this module. everything work fine except when I try to submit the subscription form with empty fields, the call to addErrorMessage($fieldName, $message, $messageType, $escapeHtml = true) is not correct and the argument $messageType is missing.

[Warning] Missing argument 3 for Form::addErrorMessage(), called in /var/www/project/newsletter/code/pagetypes/SubscriptionPage.php on line 421 and defined
dhensby commented 7 years ago

Thanks for taking the time to post to our issue tracker.

This repository is in the SilverStripe Archive which means it's a module we no longer actively support.

We're looking more to the community to provide support for these modules if users want to continue to use them.

Would you be willing to spend the time submitting a patch for this issue?

alwex commented 7 years ago

Hi, no problem.

I have submitted a pull request, do you mind accepting it in order to make it available to others? thank you.

https://github.com/silverstripe-archive/silverstripe-newsletter/pull/118

dhensby commented 7 years ago

done