Verification should be done for each mailing list subscription not per recipient

miiihi commented 11 years ago

Hi,

first, great, that you are upgrading newsletter module. It was long overdue...

But, as I'm browsing thru the code, I found a conceptual problem. Verification of subscriptions has to be done for each mailing list (or rather batch of subscriptions done in the same request) not per recipient, as it is now. Consider following scenario in the current implementation:

user subscribes to mailing list A
user confirm subscription to mailing list A
recipient is now verified
user (or anybody) subscribes to mailing list B
confirmation mail is sent, but as recipient is already verified, it is irrelevant! recipient is immediately subscribed to mailing list B

Do you see the problem?

I can offer some help with implementation of the fix, if needed...

Best regards, miiihi

normann commented 11 years ago

hi miiihi, I see the problem and am glad if you could help with the implementation.

wilr commented 6 years ago

Closing as this is > 5 years old without any progress. Please reopen if code can be provided.

Cheers

silverstripe-archive / silverstripe-newsletter

Verification should be done for each mailing list subscription not per recipient #16