search

silverstripe-archive / silverstripe-newsletter

NewsletterAdmin is the CMS class for managing the newsletter system.
BSD 3-Clause "New" or "Revised" License
69 stars 59 forks source link

Fix #39 - Anchor links in emails are broken #55

Closed ss23 closed 11 years ago

ss23 commented 11 years ago

Will avoid replacing the link if the first character is a #

wilr commented 11 years ago

UT?

ss23 commented 11 years ago

I'm willing to add tests when someone goes through and makes this module pass tests properly :D That being said, I was doing this for someone else, so I have no vested interest in getting merged ASAP.

peavers commented 11 years ago

Link still includes the baseURL.

ss23 commented 11 years ago

As pointed out by @peavers this won't work at all.

Willing to accept someone else's PR to fix this, but I don't have time to refactor the entire module to work at the moment.