search

silverstripe-archive / silverstripe-newsletter

NewsletterAdmin is the CMS class for managing the newsletter system.
BSD 3-Clause "New" or "Revised" License
69 stars 59 forks source link

FIX: MailingList ModelAdmin throwing Logic Error when no Recipients or Mailing Lists in DB #62

Closed mellm0 closed 10 years ago

mellm0 commented 10 years ago

Made sure MailingList::ActiveRecipients always returns a DataList rather than an UnsavedRelationList

ss23 commented 10 years ago

This pull request has confused me -- can you squash all of those rather than chain the commits together, so the diff is easier to read?

mellm0 commented 10 years ago

Yes, will fix the pull (sorry, got it wrong a couple of times). And will fix the DataList filter to use 'filter' rather than 'exclude'