make all statics private and refer to them using config

silverstripe-archive / silverstripe-newsletter

NewsletterAdmin is the CMS class for managing the newsletter system.

BSD 3-Clause "New" or "Revised" License

69 stars 59 forks source link

Closed sunnysideup closed 6 years ago

sunnysideup commented 10 years ago

for example:

Config::inst()->get("SubscriptionPage", "days_verification_link_alive");
//rather than
self::get::get_days_verification_link_alive()

I can create a pull request with these fixes...

ss23 commented 10 years ago

Fine with me, just raise it against the master branch :monkey_face: (and make sure it all works) :hamburger:

wilr commented 6 years ago

Fixed in features/4.0 PR