search

silverstripe-archive / silverstripe-newsletter

NewsletterAdmin is the CMS class for managing the newsletter system.
BSD 3-Clause "New" or "Revised" License
69 stars 59 forks source link

Only start session if behat-tested section is being hit. #76

Closed mateusz closed 10 years ago

mateusz commented 10 years ago

That seems to work but let's wait to see what's the result of https://github.com/silverstripe-labs/silverstripe-newsletter/pull/77

tractorcow commented 10 years ago

Why is session started here at all? Session should be initiated by core.

halkyon commented 10 years ago

...yeah, that seems like a hack and should be removed and fixed properly.

halkyon commented 10 years ago

Looks like it was already done in 460056f1fb022d974e1782eb320dc7d1b688aa88. Maybe this should be closed :)