Fix compatibity issue with BetterButtons

silverstripe-archive / silverstripe-newsletter

NewsletterAdmin is the CMS class for managing the newsletter system.

BSD 3-Clause "New" or "Revised" License

69 stars 59 forks source link

Fix compatibity issue with BetterButtons #89

Closed cjsewell closed 8 years ago

cjsewell commented 9 years ago

Better buttons changes the save action name to action_save, while newsletter expects it to be action_doSave. This does a simple check to see if action_doSave exists, if it does not, it will use action_save

cjsewell commented 9 years ago

Fixes #58

Firesphere commented 9 years ago

I wouldn't fix this this way. A better way is disable Gridfield Better Buttons via the config:

Newsletter:
  better_buttons_enabled: false

That way, the send-buttons etc. from Newsletter aren't overridden either (because better buttons does that)