silverstripe-terraformers / silverstripe-embargo-expiry

BSD 3-Clause "New" or "Revised" License
7 stars 7 forks source link

MNT: Github actions, composer requirements, linting #104

Closed mfendeksilverstripe closed 1 year ago

mfendeksilverstripe commented 1 year ago

MISC: Github actions update

mfendeksilverstripe commented 1 year ago

@chrispenny Can you please have a look at this one?

chrispenny commented 1 year ago

@mfendeksilverstripe looks good, pending broken checks.

mfendeksilverstripe commented 1 year ago

@chrispenny The failures in the checks are not caused by the changes on this branch - the news checks simply expose pre-existing issues which are:

I suggest to merge this branch and raise these two as separate issues

mfendeksilverstripe commented 1 year ago

I think this needs a bit more trial and error.

mfendeksilverstripe commented 1 year ago

Managed to fix the low end composer requirements @chrispenny. I think the rest of the issues would be out of scope for this PR.

chrispenny commented 1 year ago

The matrix that ran last week passed, so that might indicate that our existing code works with that particular matrix. If we need to upgrade code in order to upgrade the matrix, then I think that should be done at the same time(?).

Screen Shot 2022-11-29 at 8 49 02 AM

mfendeksilverstripe commented 1 year ago

This is back with you @chrispenny for a review. Those 4 last checks require this PR to be merged into master and possibly repo settings update as per https://github.com/orgs/community/discussions/26698