silverstripe-terraformers / silverstripe-embargo-expiry

BSD 3-Clause "New" or "Revised" License
7 stars 7 forks source link

ENH: Extensibility improvements (Injector use, avoid private methods). #105

Closed mfendeksilverstripe closed 1 year ago

mfendeksilverstripe commented 1 year ago

ENH: Extensibility improvements (Injector use, avoid private methods).

mfendeksilverstripe commented 1 year ago

@chrispenny Can you please review this one?

chrispenny commented 1 year ago

@mfendeksilverstripe do you need to extend those methods at the moment?

The reason to use private is to reduce the size of the API. A smaller API means we're less like to cause "breaking changes" if we happen to want to remove/refactor one of those private methods.

mfendeksilverstripe commented 1 year ago

I don't need to open up these methods ATM. Can change them back to private @chrispenny

mfendeksilverstripe commented 1 year ago

@chrispenny I've reverted the method visibility change, please review.