Doesn't work as expected in combination with Fluent

AljosaB commented 1 month ago

Expected result

Each localisation can have it's own publishing time set

Behaviour + steps

Create a page in locale1 and set publish date in future // there is a new record in QueuedJobDescriptor with locale1 written in SavedJobData
Localise page in locale2; you can see warning of emabrgo and same date as in locale1 although we didn't set the emabargo for locale2 yet
Set emabargo date for locale2 // the previous QueuedJobDescriptor record gets deleted and new one with locale2 written in SavedJobData
Extra step: switch back to locale1 and set the emargo date again // this time new QueuedJobDescriptor get's created with locale1 written in SaveJobData

Problem

After creating localisation in locale2, the warning shouldn't be displayed as we didn't set any embargo for that locale yet
After step 3 we have only one QueuedJobDescriptor for locale2 instead 2 for both locales

chrispenny commented 1 month ago

Thanks for raising this with such detailed steps to reproduce!

The bugs you've raised under With EmbargoExpiryFluentExtension definitely warrant looking in to and resolving. We need to make sure that the messaging is clear (for each locale respectively) and that the correct jobs are created and maintained.

I don't think we would spend any time on Without EmbargoExpiryFluentExtension, as the expectation would be that you do use the EmbargoExpiryFluentExtension if you have Fluent installed. I'm going to keep a record of them here, but I'm going to remove them from the Issue description so that the focus is on With EmbargoExpiryFluentExtension.

Originally in the Issue description:

Without EmbargoExpiryFluentExtension (https://github.com/silverstripe-terraformers/silverstripe-embargo-expiry/blob/master/docs/en/fluent-support.md)

How to reproduce

create a page in locale1 and set publish date in future
localise page in locale2; you can see warning of emabrgo and same date as in locale1
run dev/tasks/ProcessJobQueueTask (after the set time)

Expected result

page published in all locales

Actual result

page in locale1 still in draft
page in locale2 published

DB result

SiteTree_Live record created
SiteTree_Localised_Live record created for locale2, no new record for locale1

chrispenny commented 1 month ago

@AljosaB could you please also let us know what version of Embargo & Expiry this was experienced on?

AljosaB commented 1 week ago

@chrispenny I somehow missed your response. As instructed I always test things on latest clean SS installation (in this case SS 5.2.x) and only thing added extra was embargo-expiry v2.0.0

silverstripe-terraformers / silverstripe-embargo-expiry