silverstripe-terraformers / silverstripe-embargo-expiry

BSD 3-Clause "New" or "Revised" License
7 stars 7 forks source link

Updated rollback functionality to not remote embargo/expiry #27

Closed chrispenny closed 6 years ago

chrispenny commented 6 years ago

After some discussion it was decided that we should not dictate that an Embargo/Expiry date on old versions should be removed on rollback. We have instead updated the status message to be a "warning", with appropriate messages:

screen shot 2018-07-23 at 7 41 59 am

This message will show up in the History tab as authors browse through versions.

Importantly, this behaviour also matches the behaviour found in the SilverStripe 4 version of the Advanced Workflow module.

Developers should be free to add their own rollback behaviour to determine whether or not these dates are removed. Though, I do have an open issue on Versioned questioning if there is an appropriate place to implement this sort of behaviour: https://github.com/silverstripe/silverstripe-versioned/issues/170

chrispenny commented 6 years ago

@chillu this might be of interest to you, as you originally requested removal of Embargo/Expiry dates on rollback.

TL;DR: