After some discussion it was decided that we should not dictate that an Embargo/Expiry date on old versions should be removed on rollback. We have instead updated the status message to be a "warning", with appropriate messages:
This message will show up in the History tab as authors browse through versions.
Importantly, this behaviour also matches the behaviour found in the SilverStripe 4 version of the Advanced Workflow module.
Developers should be free to add their own rollback behaviour to determine whether or not these dates are removed. Though, I do have an open issue on Versioned questioning if there is an appropriate place to implement this sort of behaviour:
https://github.com/silverstripe/silverstripe-versioned/issues/170
After some discussion it was decided that we should not dictate that an Embargo/Expiry date on old versions should be removed on rollback. We have instead updated the status message to be a "warning", with appropriate messages:
This message will show up in the History tab as authors browse through versions.
Importantly, this behaviour also matches the behaviour found in the SilverStripe 4 version of the Advanced Workflow module.
Developers should be free to add their own rollback behaviour to determine whether or not these dates are removed. Though, I do have an open issue on Versioned questioning if there is an appropriate place to implement this sort of behaviour: https://github.com/silverstripe/silverstripe-versioned/issues/170