silverstripe-terraformers / silverstripe-embargo-expiry

BSD 3-Clause "New" or "Revised" License
7 stars 7 forks source link

Set a publish date/time hides the page blocks #70

Closed shoosah closed 4 years ago

shoosah commented 4 years ago

So I created a page (ReginonPage extens Page) with couple of Elemental blocks (https://github.com/dnadesign/silverstripe-elemental), saved and published. Then made more changes into the block and set Desired publish date/time for few hours later. Once I log out from the CMS, all of the blocks disappeared from the page which you can see below:

DesiredPublishDate

Then I logged in to the admin section and reloaded the page again. This time the page blocks shown as before! This trend happens when I'm logged out of CMS until it publishes the changes. "version": "1.0.3"

chrispenny commented 4 years ago

Thanks, @shoosah!

You mentioned that you set an Expiry, not an Embargo. Expiry is where a page is unpublished on that date. Can you please clarify if you meant you set an Embargo time, or an Expiry time?

Could you please also confirm that the Expiry and/or Embargo is set on the Page itself? And that this isn't some custom installation where E&E has been added to the individual Blocks or something.

CC: @mfendeksilverstripe

shoosah commented 4 years ago

Hey @chrispenny. Sorry for the confusion. I updated the description of the issue to be more descriptive. Please note this only happens on a specific page type (RegionPage class which is extending Page class) on our UAT environment (I wasn't able to produce this problem locally). The only thing I can see suspicious on this page type is the following part of the code:

 /**
     * @return \SilverStripe\Forms\Validator
     */
    public function getCMSValidator()
    {
        return RequiredFields::create([
            'MapRegion',
        ]);
    }

The reason is that I changed the page type to Page, published it, then changed the page type back to RegionPage (this time I didn't need to set the MapRegion). Then I logged out and I was able to see the blocks in the Region Page again!

chrispenny commented 4 years ago

After our offline chat, we've agreed to close this ticket for now. Currently not able to replicate on local environments, and is sounding project specific.

We'll re-raise if we're able to lock down what the issue is.