search

silverstripe-terraformers / silverstripe-embargo-expiry

BSD 3-Clause "New" or "Revised" License
7 stars 7 forks source link

Missing publish button on regular DataObject #83

Closed thats4shaw closed 3 years ago

thats4shaw commented 3 years ago

To replicate:

My\Namespace\DataObject:    
  extensions:
    - SilverStripe\Versioned\Versioned
    - Terraformers\EmbargoExpiry\Extension\EmbargoExpiryExtension

I have seen the following error thrown in console but can't reliably recreate it but assume it's related:

embargo-expiry.js?m=1625172243:1 Uncaught TypeError: Cannot read properties of undefined (reading 'entwine')
    at Object../client/src/bundles/embargo-expiry.js (embargo-expiry.js?m=1625172243:1)
    at t (embargo-expiry.js?m=1625172243:1)
    at embargo-expiry.js?m=1625172243:1
    at embargo-expiry.js?m=1625172243:1
thats4shaw commented 3 years ago

So this is just a bit of gotcha with the isEditable function.

Returns null, instead of true in my context so I can just override in this case.