Use DateTimeImmutable for time calculations

silverstripe-terraformers / silverstripe-embargo-expiry

BSD 3-Clause "New" or "Revised" License

7 stars 7 forks source link

Closed oddnoc closed 2 years ago

oddnoc commented 2 years ago

This avoids problems where times in the future are sometimes considered to be in the past.

Also display the time zone in CMS messages that display dates & times.

chrispenny commented 2 years ago

Thank you for the contribution! I will do my best to find some time next week to review 😄

chrispenny commented 2 years ago

Hi @oddnoc,

Have you allowed maintainers to contribute to your PR?

allow-maintainers-to-make-edits

I don't seem to be able to push to your branch. I have some minor changes and some test coverage that I would like to add.

Cheers

oddnoc commented 2 years ago

I've moved the repository to my personal account to enable you to make your edits.

chrispenny commented 2 years ago

Thanks again for the contribution, @oddnoc! I'll look to tag this up soon.