search

silverstripe-terraformers / silverstripe-embargo-expiry

BSD 3-Clause "New" or "Revised" License
7 stars 7 forks source link

Fix/replace superclosure #92

Closed alex-dna closed 2 years ago

alex-dna commented 2 years ago

The Superclosure package has been deprecated. So replacing with the suggested replacement.

chrispenny commented 2 years ago

Thanks, @alex-dna! I really appreciate you picking this up. I just need to remind myself if we have test coverage for the usage of these extension points, but it looks like it was a straight swap, which is great.

Related Issue. Closes #87

chrispenny commented 2 years ago

There is test coverage for the Fluent implementation, and I've given it a quick go on my local. All seems to be working 😄

Thanks again for the contribution @alex-dna. Merging this and tagging now.