Updating PHP 7.1 constraint to PHP 8.0

silverstripe-terraformers / silverstripe-embargo-expiry

BSD 3-Clause "New" or "Revised" License

7 stars 7 forks source link

Updating PHP 7.1 constraint to PHP 8.0 #98

Closed jareddreyerss closed 2 years ago

jareddreyerss commented 2 years ago

Because the master branch currently has PHP constraint of PHP ^7.1 whenever this module is used on PHP 8 builds the tagged RC versions are installed because they do not have a PHP version constraint.

With a PHP 8.0 constraint this will enable composer to pick up the latest releases for PHP 8 builds.

NB: Checked the unit tests and looks like fluent has issues in PHP 8 so have not updated phpunit constraint.

chrispenny commented 2 years ago

Thanks, @jareddreyerss!

We still need to support PHP 7.x as well (though, definitely not as far back as 7.1).

Silverstripe looks to be following PHP supported versions, so I would be happy for us to do the same:

"php": "^7.4 || ^8.0"

jareddreyerss commented 2 years ago

@chrispenny good call, my bad I missed that 🤣