After sass-lint was replaced by stylelint, it became necessary to bring existing code into compliance with the new rules so that all style files adhered to the basic rules.
Mostly this is a deviation from the rules in the writing and use of the color name instead of the hex code, indents before blocks and at the beginning of the file, empty comments. You need to go through all the modules from the list and run a lint check. Any warnings that occur must be corrected or removed from the list of rules in the .stylelintrc.yml file if they are not appropriate.
Acceptance criteria
[x] There are no stylelint warnings on any supported modules
[x] The 'defaultSeverity': 'warning' line is removed from .stylelintrc.js in the shared lint config
[x] Paths being ignored are evaluated - stop ignoring "legacy" code, since we're still maintaining it.
PRs
This PR must be merged first so I can update the yarn deps for all the other repos, or else the linting in CI for the PRs will be using the outdated rules.
Description
After sass-lint was replaced by stylelint, it became necessary to bring existing code into compliance with the new rules so that all style files adhered to the basic rules.
Mostly this is a deviation from the rules in the writing and use of the color name instead of the hex code, indents before blocks and at the beginning of the file, empty comments. You need to go through all the modules from the list and run a lint check. Any warnings that occur must be corrected or removed from the list of rules in the
.stylelintrc.yml
file if they are not appropriate.Acceptance criteria
'defaultSeverity': 'warning'
line is removed from.stylelintrc.js
in the shared lint configPRs
This PR must be merged first so I can update the yarn deps for all the other repos, or else the linting in CI for the PRs will be using the outdated rules.
Lint fixing PRs
Reassign to Guy if these are still draft - but make sure you merge the above PR first!