silverstripe / .github

0 stars 2 forks source link

Cow - work out why non-recipes ended up with new deps #33

Closed emteknetnz closed 1 year ago

emteknetnz commented 1 year ago

Investigate why cow did this to admin

https://github.com/silverstripe/silverstripe-admin/commit/dceb3e8e9e4e17132f957a4d142020319711be23

It shouldn't have - was reverted in this PR - https://github.com/silverstripe/silverstripe-admin/pull/1480

Note only did this for 4.13-beta1, haven't seen this happen for anything else including 5.0.0-beta1, so this is low priority This happened to most if not all non-recipes and will result in a bad constraint on stable if we don't fix it now.

There's a list of affected modules in a comment below. When reviewing, make sure each affected module has a PR (in case I missed one)

PRs

GuySartorelli commented 1 year ago

The following modules were affected. When reviewing this work, make sure there's a PR for each of these:

GuySartorelli commented 1 year ago

All PRs merged